smarty: Add a special case for 's at the beginning of the token#1348
Merged
waylan merged 1 commit intoPython-Markdown:masterfrom May 22, 2023
Merged
smarty: Add a special case for 's at the beginning of the token#1348waylan merged 1 commit intoPython-Markdown:masterfrom
waylan merged 1 commit intoPython-Markdown:masterfrom
Conversation
When 's is not preceded by anything, it probably means that it comes after some HTML tag, so it should be converted to a closing quote. The reference Perl implementation makes the close_class optional and adds a lookahead check for (\s|s\b) when close_class was not matched. Let's copy that behavior by removing closeClass lookbehind check from closingSingleQuotesRegex2. Fixes Python-Markdown#1305.
111e2c5 to
d3739c9
Compare
waylan
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
'sis not preceded by anything, it probably means that it comes after some HTML tag, so it should be converted to a closing quote.The reference Perl implementation makes the close_class optional and adds a lookahead check for
(\s|s\b)when close_class was not matched:Let's copy that behavior by removing closeClass lookbehind check from closingSingleQuotesRegex2.
Fixes #1305.