Merged
Conversation
Seems to have been there since the beginning.
Add the formula and also explicitly note the default depth value. Also clean up the docstring for weighted_continuous_average a bit, too.
dopplershift
added
Type: Bug
dcamron
approved these changes
Mar 28, 2023
Member
dcamron
left a comment
dcamron
left a comment
There was a problem hiding this comment.
Looks good. Not sure if there's more we should do about clarifying the "depth defines p_s" behavior here and now. I guess I'd save that until we heard more headache first.
Member
Author
|
Yeah, unless there are some immediate thoughts on improvement, I'd leave that TBD. "Perfect enemy of the good" and all that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
mean_pressure_weighteddocstring based on these Stack Overflow questionsweighted_continuous_averagedocstringChecklist