unit redefinition help for /s#2994
Merged
dopplershift merged 1 commit intoUnidata:mainfrom Apr 7, 2023
Merged
Conversation
7b14c28 to
514a8f8
Compare
dopplershift
requested changes
Apr 7, 2023
Member
dopplershift
left a comment
There was a problem hiding this comment.
Thanks for fixing it up! I think I have a somewhat simpler solution for the pre-processor.
514a8f8 to
22266ab
Compare
dopplershift
approved these changes
Apr 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
The issue has arisen with older model output data where the stored vorticity unit is
/s, which will then fail on any action with a unit with the errorpint.errors.DefinitionSyntaxError: missing unary operator "/". This solution adds a small fix in the units module to replace/swiths**-1. An example dataset that this occurs with is older GFS data available through the RDA archive.Minimum example to produce error: