Merged
Conversation
This format is expressed easily enough using our existing IOBuffer class, so just put the unpacking methods directly in Level3XDRParser and use IOBuffer for unpacking.
dopplershift
force-pushed
the
add-xdr-lib-submodule
branch
from
ef4225a to
d2a3abb
Compare
Member
|
Thanks for the initial cut of this! Based on that, I could see we could almost trivially write this using our existing @dcamron can you review since I have code on this now? |
Member
|
We could definitely compress this down further, but I feel like this is a good balance of not modifying the original XDR client code we had, and instead it just replaces the parts from |
dcamron
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Moves xdrlib class into MetPy
Checklist