Add mpl_args and PlotGeometry stroke_width#3183
Merged
dopplershift merged 6 commits intoUnidata:mainfrom Oct 18, 2023
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @needs_cartopy | ||
| def test_declarative_raster_options(): | ||
| """Test making a raster plot.""" | ||
| data = xr.open_dataset(get_test_data('narr_example.nc', as_file_obj=False)) |
Check warning
Code scanning / CodeQL
File is not always closed
kgoebber
force-pushed
the
add_mpl_args
branch
from
99d0a28 to
d6e0808
Compare
2 tasks
dopplershift
added
Type: Enhancement
dopplershift
requested changes
Oct 18, 2023
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Minor typo, but otherwise this looks ready.
kgoebber
force-pushed
the
add_mpl_args
branch
from
d6e0808 to
1561287
Compare
dopplershift
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR implements a number of improvements to the declarative interface to allow for additional kwargs to alter how a data element is plotted. Primarily this adds a new trait called
mpl_argsfor all declarative plot classes and is designed to be a dictionary of values. Additionally, this PR adds thestroke_widthtrait for PlotGeometry since it would be a heavily used element that we wish to expose according to issue #2719. This would also allow for more nuanced use of alpha and zorder as discussed in #2746.Checklist
PlotGeometrymissing trait for stroke width #2719 and Zorder for metpy.BarbPlot #2746