Fix galvez_davison_index error: invalid index to scalar variable#3529
Merged
dopplershift merged 4 commits intoUnidata:mainfrom Jul 9, 2024
Merged
Fix galvez_davison_index error: invalid index to scalar variable#3529dopplershift merged 4 commits intoUnidata:mainfrom
dopplershift merged 4 commits intoUnidata:mainfrom
Conversation
Member
|
Is there an easy test you could add based on how you were using the function when it errored? |
0d arrays is deprecated on line:4594, when test with simple value.
Contributor
Author
|
I apologize for making you wait. I add new test function with simple value and found new problem "DeprecationWarning: Calling nonzero on 0d arrays is deprecated". That cause from indices_without_950 too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Fix galvez_davison_index error when missing data at 950 hPa. In raise ValueError at:
f'\n{np.max(pressure, axis=0)[indices_without_950]}'It show error message: "invalid index to scalar variable". This cause from [indices_without_950] behind the np.max().
Checklist