Remove duplicate error display in generate Alt text#255
Remove duplicate error display in generate Alt text#255gziolo merged 9 commits intoWordPress:developfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #255 +/- ##
==========================================
Coverage 58.03% 58.03%
Complexity 576 576
==========================================
Files 37 37
Lines 2955 2955
==========================================
Hits 1715 1715
Misses 1240 1240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@karmatosed is there a standard approach within Gutenberg for this sort of error in terms of showing it at the top of the canvas or contextually within the sidebar? Which is the most optimal approach? |
|
@juanfra per input from @karmatosed in Slack, let's remove the error from the top of the canvas and keep the one in the sidebar. |
|
Thanks @jeffpaul! I shared my thoughts on that thread but maybe it's worth to centralize the conversation here. I don't think we have a precedent for showing errors in the sidebar. If we set one here, it might mean revisiting how other experiments with sidebar controls handle errors too. Errors at the top feel more consistent with existing block editor patterns, and how we're doing it for the rest of the experiments. Happy to revisit if there are examples of this pattern elsewhere that I'm missing. |
|
@karmatosed can you confirm optional approach to align to how Gutenberg handles contextual error messages (feel free to ping Gutenberg designers/engineers to verify if needed)? |
@jorgefilipecosta or @Mamaduka, what's the latest on showing errors in the UI: global snackbar (kept in this PR) or inline error notice (removed in this PR). |
|
As far as I know, we're still using snackbars for most cases. I think it will remain the same until normal notices are more flexible. |
gziolo
left a comment
There was a problem hiding this comment.
Looks good. We can iterate when design recommendations change over time.
What?
Removes the error message from the controls area when AI summary generation fails.
Why?
Errors were being displayed twice. Once in the top notice bar and again right above the button. This redundancy was confusing and you had to dismiss the two independently.
How?
Removed the error display from the controls area
Testing Instructions
Screenshots or screencast
Before
generate-alt-duplicated-error.mp4
After