Merged
Conversation
This doesn't break any extensions NOT using IDataPack, and we do not know of any that are. * The extension storage utility of this interface has been broken for the last 9 months, with ISourceMod::CreateDataPack being disabled. * The plugin interop utility of this interface (its stated purpose) has been broken for the last 11+ years, with ISourceMod::GetDataPackHandleType being disabled. I imagine it only survived the first cleanup 11 years ago because CSS:DM was using it internally, which it has now been migrated away from. Compiled all the included extensions without changes (API compat), and loaded extensions build pre-change without issue (ABI compat).
Member
|
You could copy the documentation from IDataPack.h to the CDataPack header. |
Headline
reviewed
Jul 31, 2018
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
If we do toss IDataPack into the incinerator, this looks good. One question inline
| // Add 1 to the RHS of this expression to bump the intercom file | ||
| // This is to prevent mismatching core/logic binaries | ||
| static const uint32_t SM_LOGIC_MAGIC = 0x0F47C0DE - 56; | ||
| static const uint32_t SM_LOGIC_MAGIC = 0x0F47C0DE - 57; |
Member
There was a problem hiding this comment.
If we fwd-decl'd IDataPack in the SourceMod namespace and didn't change the iface declarations of CreateDataPack and FreeDataPack in sourcemod.h, could we prevent bumping this?
Member
Author
There was a problem hiding this comment.
The bump here is because I've removed the functions from the bridge (which were only being used by ISourceMod), we could just leave them in the bridge (even just as null ptrs) to avoid bumping this, but logic bridge iface bumps are not a problem, it is just to prevent against accidents.
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't break any extensions NOT using IDataPack, and we do not know of any that are.
I imagine it only survived the first cleanup 11 years ago because CSS:DM was using it internally, which it has now been migrated away from.
Compiled all the included extensions without changes (API compat), and loaded extensions built pre-change without issue (ABI compat).