exp::compiler::source-manager - added createFromBuffer method#423
Merged
dvander merged 1 commit intoalliedmodders:masterfrom Nov 26, 2019
rumblefrog:master
Merged
exp::compiler::source-manager - added createFromBuffer method#423dvander merged 1 commit intoalliedmodders:masterfrom rumblefrog:master
dvander merged 1 commit intoalliedmodders:masterfrom
rumblefrog:master
Conversation
Adds SourceManager::createFromBuffer to allow creation from a buffer instead of file path The path param should be unique when passing
dvander
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief
Adds SourceManager::createFromBuffer to allow creation from a buffer instead of file path
Motivation
In wasm targets, local file creation are not possible, this method allows the creation of RefPtr from a buffer instead.