Skip to content

refactor(partition-mapper): rename ToXXXMapper to StartOfXXXMapper#64160

Merged
Lee-W merged 3 commits intoapache:mainfrom
astronomer:rename-mappers
Mar 27, 2026
Merged

refactor(partition-mapper): rename ToXXXMapper to StartOfXXXMapper#64160
Lee-W merged 3 commits intoapache:mainfrom
astronomer:rename-mappers

Conversation

@Lee-W
Copy link
Copy Markdown
Member

@Lee-W Lee-W commented Mar 24, 2026

Why

During b2 testing, I received feedback that ToXXXMapper was still confusing.

What

rename ToXXXMapper to StartOfXXXMapper


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@Lee-W Lee-W added this to the Airflow 3.2.0 milestone Mar 24, 2026
@Lee-W Lee-W self-assigned this Mar 24, 2026
@Lee-W Lee-W marked this pull request as draft March 25, 2026 06:47
@Lee-W Lee-W changed the title refactor(partition-mapper): rename ToXXXMapper to TruncateToXXXMapper refactor(partition-mapper): rename ToXXXMapper to StartOfXXXMapper Mar 25, 2026
@Lee-W
Copy link
Copy Markdown
Member Author

Lee-W commented Mar 25, 2026

@uranusjr Since we're now renaming it to StartOfXXXMapper now, we probably can include the full timestamp? or should we? so for a StartOfMonthMapper, it currently generates a partition key like 2027-01

@uranusjr
Copy link
Copy Markdown
Member

I think it’s fine to truncate the key, people probably aren’t interested in those extra zeros.

@Lee-W Lee-W marked this pull request as ready for review March 26, 2026 06:52
Copy link
Copy Markdown
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically approve, I just double-checked for all the renaming, but I didn't go deep with the discussion thread.

@Lee-W Lee-W merged commit 3bb2dd5 into apache:main Mar 27, 2026
113 checks passed
@Lee-W Lee-W deleted the rename-mappers branch March 27, 2026 06:55
vatsrahul1001 pushed a commit that referenced this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants