Fix handling of imports involving synthetic case class objects#1231
Merged
lihaoyi merged 2 commits intocom-lihaoyi:masterfrom Dec 2, 2021
Merged
Fix handling of imports involving synthetic case class objects#1231lihaoyi merged 2 commits intocom-lihaoyi:masterfrom
lihaoyi merged 2 commits intocom-lihaoyi:masterfrom
Conversation
Collaborator
alexarchambault
left a comment
alexarchambault
left a comment
There was a problem hiding this comment.
Apart from what's mentioned in the comments, LGTM!
Member
Author
|
@alexarchambault thanks for the pointers, test suite is green now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #474
Turns out that even though the companion object for a
case class Foois marked as synthetic, it can still be imported and used. Thus when determining imports, we should not filter out synthetic symbolsAdded tests including the original repro, as well as a minimized repro. Both tests fail on master, pass on this PR