[2.x] fix(core): add missing method_not_allowed translation for error view#4418
Merged
[2.x] fix(core): add missing method_not_allowed translation for error view#4418
Conversation
Fixes #4238 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4238 (2.x counterpart to #4417)
When a
MethodNotAllowedExceptionis thrown, the HTTP 405 status code was correctly set, but the error page displayed the generic "An error occurred while trying to load this page." message instead of a specific one.ViewFormatter::getMessage()looks upcore.views.error.{type}— if the key doesn't exist, the translator returns the key itself, which is detected as a miss and falls through to the generic message. Adding the missingmethod_not_allowedtranslation key fixes this.Test plan
/login)🤖 Generated with Claude Code