[2.x] feat(install): support queue configuration in installer file#4484
Merged
[2.x] feat(install): support queue configuration in installer file#4484
Conversation
FileDataProvider now reads a 'queue' key from the JSON/YAML installer
config file and passes it through to StoreConfig via Installation.
Previously the queue config in config.php was always hardcoded to
['driver' => 'sync'], requiring a manual post-install edit for any
other driver. Now it can be set at install time:
{
"baseUrl": "https://example.com",
"databaseConfiguration": { ... },
"queue": { "driver": "database" }
}
Defaults to ['driver' => 'sync'] when the key is absent, preserving
existing behaviour.
Closes #4469
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4469.
FileDataProvidernow reads aqueuekey from the JSON/YAML installer config file and passes it through toStoreConfigviaInstallation. Previously the queue config inconfig.phpwas always hardcoded to['driver' => 'sync'], requiring a manual post-install edit for any other driver.Usage
{ "baseUrl": "https://example.com", "databaseConfiguration": { "..." }, "queue": { "driver": "database" } }Omitting the
queuekey defaults to['driver' => 'sync'], preserving existing behaviour.Changes
FileDataProvider— readsqueuefrom config, defaults to['driver' => 'sync']Installation— addsqueueConfig(array $queue): selffluent methodStoreConfig— accepts queue config as constructor param (default['driver' => 'sync']), uses it inbuildConfig()instead of hardcoded valueTest plan
"queue": {"driver": "database"}and verifyconfig.phpcontains the correct queue configqueuekey and verifyconfig.phpstill defaults tosync