Conversation
imorland
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
twemojipackage with@twemoji/apiReviewers should focus on:
I don't love the CDN url being set by default in the backend, as a user can go in and modify it and save such that it may be equal to the default, but now has a value in their DB and so it's technically a custom CDN. Though this shouldn't come up very often. I'd rather have it as a constant in the common JS and pass that when missing a setting (and to the locale -- should not be in the translation text imo).
Also, regarding CDN: For fof/reactions (see FriendsOfFlarum/reactions@d0d60a6), I used Emoji/Unicode 16 since the CDN we use (cloudflare's cdnjs) does not have the latest version (see cdnjs/cdnjs#14263). We use jsdelivr as a default here, but it may cause issues with those that use a custom one to avoid geoblocking?
Screenshot


Necessity
For core PRs, does this need to be in core, or could it be in an extension?Confirmed
composer test).