node/npm screenshot version update#10612
Closed
NoriSte wants to merge 1 commit intogatsbyjs:masterfrom
NoriSte:master
Closed
node/npm screenshot version update#10612NoriSte wants to merge 1 commit intogatsbyjs:masterfrom NoriSte:master
NoriSte wants to merge 1 commit intogatsbyjs:masterfrom
NoriSte:master
Conversation
A colleague of mine has been led to the error from the version shown in the old screenshot. With the versions of the old screenshot, the installation fails
|
I am seeing the same error currently and have been trying to resolve it all morning. By moving from Node 8 to Node 10, it resolved my issue. |
Contributor
|
Our Appveyor builds are also failing with the same error; so this seems to be some issue with one of our dependencies in that particular node version, correct? https://ci.appveyor.com/project/KyleAMathews/gatsby/builds/21176198/job/31arqy7c3y238xf5 |
Contributor
|
This possibly was introduced with #10593 so it could be worth investigating that further. |
DSchau
pushed a commit
that referenced
this pull request
Dec 21, 2018
<!-- Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or ask in this Pull Request and a Gatsby maintainer will be happy to help :) --> ## Description <!-- Write a brief description of the changes introduced by this PR --> This fixes a bug introduced in #10593 by replacing the `.off` call with `.removeListener`. `.off` was introduced in Node v10.0.0 as an alias for `.removeListener` (nodejs/node#17156). ## Related Issues <!-- Link to the issue that is fixed by this PR (if there is one) e.g. Fixes #1234, Addresses #1234, Related to #1234, etc. --> Related to #10612
Contributor
|
The underlying issue was closed out in #10613, so going to close this out. Please re-open if you think this is a mistake or if we can help out further. Thanks again! |
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
<!-- Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or ask in this Pull Request and a Gatsby maintainer will be happy to help :) --> ## Description <!-- Write a brief description of the changes introduced by this PR --> This fixes a bug introduced in gatsbyjs#10593 by replacing the `.off` call with `.removeListener`. `.off` was introduced in Node v10.0.0 as an alias for `.removeListener` (nodejs/node#17156). ## Related Issues <!-- Link to the issue that is fixed by this PR (if there is one) e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc. --> Related to gatsbyjs#10612
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A colleague of mine has been led to the error from the version shown in the old screenshot. With the versions of the old screenshot, the installation fails
Related Issues
I fixed all my own the issue but if you'd like to have a detailed description... below you can find the steps to reproduce the issue that make me submit this PR
$ node --version
v8.11.1 # it happens with v8.11.3 too
$ mkdir gastby
$ cd gatsby
$ npx gatsby new gatsby-site
$ cd gatsby-site
$ yarn gatsby develop
Environment
System: OS: macOS High Sierra 10.13.6 CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz Shell: 3.2.57 - /bin/bash Binaries: Node: 8.11.1 - /usr/local/bin/node Yarn: 1.9.2 - /usr/local/bin/yarn npm: 5.6.0 - /usr/local/bin/npm npmPackages: gatsby: ^2.0.53 => 2.0.74 gatsby-image: ^2.0.20 => 2.0.25 gatsby-plugin-manifest: ^2.0.9 => 2.0.12 gatsby-plugin-offline: ^2.0.16 => 2.0.20 gatsby-plugin-react-helmet: ^3.0.2 => 3.0.5 gatsby-plugin-sharp: ^2.0.14 => 2.0.16 gatsby-source-filesystem: ^2.0.8 => 2.0.12 gatsby-transformer-sharp: ^2.1.8 => 2.1.9