Terminal: move workbench dependencies into electron-sandbox

[bpasero]

Now that the terminals are managed from the shared process it would be great if this dependency here:

vscode/src/vs/workbench/workbench.desktop.main.ts

Lines 133 to 134 in 79a623d

	// Terminal
	import 'vs/workbench/contrib/terminal/electron-browser/terminal.contribution';

Could fully move into electron-sandbox (into src/vs/workbench/workbench.sandbox.main.ts) so that we can even test it from running scripts/code.sh --__sandbox

[bpasero]

It looks like we have a terminal contribution already in sandbox:

vscode/src/vs/workbench/workbench.sandbox.main.ts

Line 117 in a9536c3

import 'vs/workbench/contrib/terminal/electron-sandbox/terminal.contribution';

But I guess those are just a few pieces of it.

[Tyriar]

Had this in mind for March already, closing #116463 off in favor of this.

[bpasero]

Slightly related, we seem to still have a native module dependency windows-process-tree in renderer that then also should move.

[bpasero]

@Tyriar just noticed this externalTerminal contrib too:

vscode/src/vs/workbench/workbench.desktop.main.ts

Line 136 in c41922b

import 'vs/workbench/contrib/externalTerminal/node/externalTerminal.contribution';

Is that a separate issue to look at?

[Tyriar]

Yes let's track that separately