feat: hoist shared libs to PRODUCT_DIR for all platforms#69
Merged
Conversation
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Oct 13, 2020
ryzokuken
approved these changes
Oct 13, 2020
Contributor
|
@targos wdyt? |
targos
approved these changes
Oct 13, 2020
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
I have no objections, since all builds were successful in the Node.js PR.
rvagg
added a commit
to ryzokuken/node
that referenced
this pull request
Oct 14, 2020
ryzokuken
pushed a commit
to nodejs/node
that referenced
this pull request
Oct 14, 2020
Ref: nodejs/node-gyp#2233 Ref: nodejs/gyp-next#69 PR-URL: #35635 Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
BethGriggs
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 8, 2020
Ref: nodejs/node-gyp#2233 Ref: nodejs/gyp-next#69 PR-URL: #35635 Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Ref: nodejs/node-gyp#2233 Ref: nodejs/gyp-next#69 PR-URL: nodejs#35635 Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: nodejs/node-gyp#2233
"feat"? 🤷