build(deps): bump remark-lint-final-definition from 3.1.2 to 4.0.0#511
Closed
dependabot[bot] wants to merge 1 commit intomainfrom
Closed
build(deps): bump remark-lint-final-definition from 3.1.2 to 4.0.0#511dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
264b8ff to
0ea135d
Compare
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 10, 2024
remark-lint-final-definition@4.0.0 will start flagging footnotes in BUILDING.md. I don't think we want to move them to the bottom, so I've disabled the lint rule where relevant. Ref: nodejs/remark-preset-lint-node#511
This comment was marked as resolved.
This comment was marked as resolved.
edb0ca2 to
13371b5
Compare
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 10, 2024
remark-lint-final-definition@4.0.0 will start flagging footnotes in BUILDING.md. I don't think we want to move them to the bottom, so I've disabled the lint rule where relevant. Ref: nodejs/remark-preset-lint-node#511 PR-URL: #52454 Refs: nodejs/remark-preset-lint-node#511 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
4cd2f54 to
437e02f
Compare
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 12, 2024
A line break in a definition ends the definition, causing an error with upcoming changes to the linter and possibly other tools. This (or some other change) is needed for nodejs/remark-preset-lint-node#511. Refs: nodejs/remark-preset-lint-node#511
Bumps [remark-lint-final-definition](https://github.com/remarkjs/remark-lint) from 3.1.2 to 4.0.0. - [Release notes](https://github.com/remarkjs/remark-lint/releases) - [Changelog](https://github.com/remarkjs/remark-lint/blob/4.0.0/history.md) - [Commits](https://github.com/remarkjs/remark-lint/commits/4.0.0) --- updated-dependencies: - dependency-name: remark-lint-final-definition dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
437e02f to
c785013
Compare
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 17, 2024
The new version of remark-lint-final-definition flags two things in our docs. These changes are needed before we land the updated package in our markdown linter. Refs: nodejs/remark-preset-lint-node#511
This comment was marked as outdated.
This comment was marked as outdated.
Member
Contributor
Author
|
Looks like remark-lint-final-definition is up-to-date now, so this is no longer needed. |
marco-ippolito
pushed a commit
to nodejs/node
that referenced
this pull request
May 2, 2024
remark-lint-final-definition@4.0.0 will start flagging footnotes in BUILDING.md. I don't think we want to move them to the bottom, so I've disabled the lint rule where relevant. Ref: nodejs/remark-preset-lint-node#511 PR-URL: #52454 Refs: nodejs/remark-preset-lint-node#511 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
marco-ippolito
pushed a commit
to nodejs/node
that referenced
this pull request
May 3, 2024
remark-lint-final-definition@4.0.0 will start flagging footnotes in BUILDING.md. I don't think we want to move them to the bottom, so I've disabled the lint rule where relevant. Ref: nodejs/remark-preset-lint-node#511 PR-URL: #52454 Refs: nodejs/remark-preset-lint-node#511 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps remark-lint-final-definition from 3.1.2 to 4.0.0.
Changelog
Sourced from remark-lint-final-definition's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)