fix: consolidate split-package-names#4632
Merged
lukekarrys merged 1 commit intolatestfrom Mar 30, 2022
Merged
Conversation
Contributor
|
found 1 benchmarks with statistically significant performance improvements
timing results
|
It was only ever used by `npm edit` so it's inline now. Rewrote `npm edit` tests to be real
b52a152 to
05791db
Compare
lukekarrys
approved these changes
Mar 30, 2022
Contributor
lukekarrys
left a comment
There was a problem hiding this comment.
Approved with one question that I was curious about.
| t.teardown(() => { | ||
| spawk.clean() | ||
| }) | ||
|
|
Contributor
There was a problem hiding this comment.
Previously spawk was calling clean after the teardown of some invididual tests. Is that the same thing as calling spawk.done() in afterEach and then spawk.unload() once at the end of all the tests?
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was only ever used by
npm editso it's inline now.Rewrote
npm edittests to be real