feat: allow checkPlatform to override execution environment

[yukukotani]

This PR allows checkPlatform to override execution environment which comes from process.platform and process.arch by default.

This will be required to achieve npm/rfcs#612

References

[wraithgar]

Since we're defaulting environment to {} here we don't need the environment && guard.

[yukukotani]

@wraithgar Callers of this function may still pass null or undefined for this argument while the default value is {}. How about leaving the environment && guard as it is and changing the default value to undefined?

[wraithgar]

We typically don't guard against bad input. It (arguably unnecessarily) increases the cognitive load of maintaining this module. This is a style choice inside of the npm codebase, we don't need to support the extra falsey value, folks consuming this can omit the parameter.

[yukukotani]

@wraithgar Okay, that makes sense! Let's prioritize the consistency across the codebase. 76b0df6

[wraithgar]

This is going to need tests.

[yukukotani]

I've added tests here: d9b4234

[yukukotani]

updated the PR title

[wraithgar]

the PR title linting is broken, had a snafu w/ the template-oss template. Don't worry about it.

[yukukotani]

@wraithgar Hi, sorry for bothering you but let me kindly remind.

When is this getting released and included in npm/cli? I'd like to start working on npm/rfcs#612.

[lukekarrys]

@yukukotani This will be released with the next npm 10 prerelease which should go out on 2023-08-16. Our main focus is currently to release npm 10 but once that is complete we will be able to backport this feature to npm 9 as well.