Update subprocess.Popen documentation wrt universal_newlines arg#10337
Merged
miss-islington merged 1 commit intopython:masterfrom Nov 12, 2018
Merged
Conversation
* universal_newlines defaulting to False would suggest, that not specifying universal_newlines explicitly and setting text to True should cause an error, which is not the case. * The run function didn't have the universal_newlines parameter documented * The check_output function didn't have its text parameter documented
Mariatta
approved these changes
Nov 12, 2018
Mariatta
changed the title
Contributor
|
Thanks @jstasiak for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-10475 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 12, 2018
…honGH-10337) * universal_newlines defaulting to False would suggest, that not specifying universal_newlines explicitly and setting text to True should cause an error, which is not the case. * The run function didn't have the universal_newlines parameter documented * The check_output function didn't have its text parameter documented (cherry picked from commit 7432f09) Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
miss-islington
added a commit
that referenced
this pull request
Nov 12, 2018
…10337) * universal_newlines defaulting to False would suggest, that not specifying universal_newlines explicitly and setting text to True should cause an error, which is not the case. * The run function didn't have the universal_newlines parameter documented * The check_output function didn't have its text parameter documented (cherry picked from commit 7432f09) Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
specifying universal_newlines explicitly and setting text to True
should cause an error, which is not the case.
documented