Improve grammar in Glossary.#10474
Merged
miss-islington merged 2 commits intopython:masterfrom Nov 12, 2018
Merged
Conversation
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Maybe some of proposed changes are correct, but most of them look incorrect to me. Although I can be wrong.
Doc/whatsnew/3.7.rst
Outdated
| (Contributed by Yury Selivanov in :issue:`32327`.) | ||
|
|
||
| * :attr:`asyncio.Server.sockets` now returns a copy of the internal list | ||
| * :attr:`asyncio.Server.sockets` now return a copy of the internal list |
Member
There was a problem hiding this comment.
I don't think this is correct.
Doc/whatsnew/3.7.rst
Outdated
|
|
||
| Regular expressions compiled with the :const:`re.LOCALE` flag no longer | ||
| depend on the locale at compile time. Locale settings are applied only | ||
| depends on the locale at compile time. Locale settings are applied only |
Member
There was a problem hiding this comment.
I don't think this is correct.
Doc/whatsnew/3.7.rst
Outdated
| Nathaniel J. Smith in :issue:`29728`.) | ||
|
|
||
| Support for :data:`socket.AF_VSOCK` sockets has been added to allow | ||
| Support for :data:`socket.AF_VSOCK` sockets have been added to allow |
Member
There was a problem hiding this comment.
I have doubts about this.
Doc/whatsnew/3.7.rst
Outdated
|
|
||
| The ``subprocess.run`` function and the :class:`subprocess.Popen` constructor | ||
| now accept the *text* keyword argument as an alias | ||
| now accepts the *text* keyword argument as an alias |
Member
There was a problem hiding this comment.
I have doubts about this.
Doc/whatsnew/3.7.rst
Outdated
|
|
||
| The ``PyExc_RecursionErrorInst`` singleton that was part of the public API | ||
| has been removed as its members being never cleared may cause a segfault | ||
| has been removed as its members were never cleared may cause a segfault |
Member
There was a problem hiding this comment.
I have doubts about this.
Doc/whatsnew/3.7.rst
Outdated
| in :issue:`32403`) | ||
|
|
||
| The speed of comparison of :class:`array.array` instances has been | ||
| The speed of comparison of :class:`array.array` instances have been |
Member
There was a problem hiding this comment.
I don't think this is correct.
Doc/whatsnew/3.7.rst
Outdated
|
|
||
| Support for directly ``await``-ing instances of :class:`asyncio.Lock` and | ||
| other asyncio synchronization primitives has been deprecated. An | ||
| other asyncio synchronization primitives have been deprecated. An |
Member
There was a problem hiding this comment.
I have doubts about this.
Contributor
Author
|
Thank you @serhiy-storchaka, I deleted the one I also not sure. |
Member
|
I look through the first commit, and I agree with @serhiy-storchaka. The current changeset looks good. |
Mariatta
approved these changes
Nov 12, 2018
Mariatta
changed the title
Contributor
|
Thanks @Windsooon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 12, 2018
a asynchronous generator -> an asynchronous generator (cherry picked from commit a9655b7) Co-authored-by: Windson yang <wiwindson@outlook.com>
|
GH-10490 is a backport of this pull request to the 3.7 branch. |
|
GH-10491 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 12, 2018
a asynchronous generator -> an asynchronous generator (cherry picked from commit a9655b7) Co-authored-by: Windson yang <wiwindson@outlook.com>
miss-islington
added a commit
that referenced
this pull request
Nov 12, 2018
a asynchronous generator -> an asynchronous generator (cherry picked from commit a9655b7) Co-authored-by: Windson yang <wiwindson@outlook.com>
miss-islington
added a commit
that referenced
this pull request
Nov 12, 2018
a asynchronous generator -> an asynchronous generator (cherry picked from commit a9655b7) Co-authored-by: Windson yang <wiwindson@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a asynchronous generator -> an asynchronous generator