Skip to content

bpo-35426: Eliminate race condition in test_interprocess_signal#11087

Merged
pablogsal merged 1 commit intopython:masterfrom
pablogsal:bpo35426
Dec 11, 2018
Merged

bpo-35426: Eliminate race condition in test_interprocess_signal#11087
pablogsal merged 1 commit intopython:masterfrom
pablogsal:bpo35426

Conversation

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal pablogsal commented Dec 10, 2018 •
edited by bedevere-bot
Loading

@pablogsal pablogsal added tests Tests in the Lib/test dir skip news labels Dec 10, 2018
@pablogsal pablogsal self-assigned this Dec 10, 2018
@pablogsal pablogsal requested a review from vstinner December 10, 2018 22:53
eamanu
eamanu approved these changes Dec 10, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vstinner
vstinner approved these changes Dec 11, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal pablogsal merged commit 2ab2afd into python:master Dec 11, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 11, 2018

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the bpo35426 branch December 11, 2018 11:32
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 11, 2018

GH-11113 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2018
@pablogsal @miss-islington
bpo-35426: Eliminate race condition in test_interprocess_signal (pyth…
8483b18 
…onGH-11087)

The test only except SIGUSR1Exception inside wait_signal(), but the signal can be sent during subprocess_send_signal() call.
(cherry picked from commit 2ab2afd)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 11, 2018

GH-11114 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2018
@pablogsal @miss-islington
bpo-35426: Eliminate race condition in test_interprocess_signal (pyth…
ed89a4b 
…onGH-11087)

The test only except SIGUSR1Exception inside wait_signal(), but the signal can be sent during subprocess_send_signal() call.
(cherry picked from commit 2ab2afd)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Dec 11, 2018
@miss-islington @pablogsal
bpo-35426: Eliminate race condition in test_interprocess_signal (GH-1…
f7404a5 
…1087)

The test only except SIGUSR1Exception inside wait_signal(), but the signal can be sent during subprocess_send_signal() call.
(cherry picked from commit 2ab2afd)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Dec 11, 2018
@miss-islington @pablogsal
bpo-35426: Eliminate race condition in test_interprocess_signal (GH-1…
869e23e 
…1087)

The test only except SIGUSR1Exception inside wait_signal(), but the signal can be sent during subprocess_send_signal() call.
(cherry picked from commit 2ab2afd)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pablogsal pablogsal

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @miss-islington @bedevere-bot @vstinner @eamanu @the-knights-who-say-ni