bpo-19696: Replace deprecated method in "test_import_pkg.py"#14466
Merged
miss-islington merged 4 commits intopython:masterfrom Jul 3, 2019
Merged
bpo-19696: Replace deprecated method in "test_import_pkg.py"#14466miss-islington merged 4 commits intopython:masterfrom
miss-islington merged 4 commits intopython:masterfrom
Conversation
Replaced deprecated method "random.choose" with "random.choice" (https://docs.python.org/3/library/random.html).
This will be my third PR to the cpython repository, forgot to add my name in the previous ones.
aeros
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
When I added my name to the file, I accidentally created a new line at the end. This should fix the commit errors.
brettcannon
approved these changes
Jul 3, 2019
Member
|
Thanks! |
swapnilraj
added a commit
to swapnilraj/cpython
that referenced
this pull request
Jul 3, 2019
* 'master' of https://github.com/swapnilraj/cpython: bpo-19696: Replace deprecated method in "test_import_pkg.py" (pythonGH-14466)
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…H-14466) Replacing the deprecated method "random.choose" to "random.choice" was technically not part of the original issue. However, it was discussed in the talk page and involved one of the files being moved. I assumed this was too minor to justify the creation of a separate issue. Also, I added my name to the contributors list in Misc/ACKS. This will be my third PR to cpython, forgot to do it in the previous ones. https://bugs.python.org/issue19696
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…H-14466) Replacing the deprecated method "random.choose" to "random.choice" was technically not part of the original issue. However, it was discussed in the talk page and involved one of the files being moved. I assumed this was too minor to justify the creation of a separate issue. Also, I added my name to the contributors list in Misc/ACKS. This will be my third PR to cpython, forgot to do it in the previous ones. https://bugs.python.org/issue19696
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing the deprecated method "random.choose" to "random.choice" was technically not part of the original issue. However, it was discussed in the talk page and involved one of the files being moved. I assumed this was too minor to justify the creation of a separate issue.
Also, I added my name to the contributors list in Misc/ACKS. This will be my third PR to cpython, forgot to do it in the previous ones.
https://bugs.python.org/issue19696