Skip to content

bpo-36168: Lowercase the word "subsequent" in get_value doc#14485

Merged
miss-islington merged 1 commit intopython:masterfrom
kmoza:master
Jul 1, 2019
Merged

bpo-36168: Lowercase the word "subsequent" in get_value doc#14485
miss-islington merged 1 commit intopython:masterfrom
kmoza:master

Conversation

@kmoza
Copy link
Copy Markdown
Contributor

@kmoza kmoza commented Jun 30, 2019 •
edited by Mariatta
Loading

Subsequent -> subsequent

https://bugs.python.org/issue36168

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Jun 30, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jun 30, 2019
@kmoza
Copy link
Copy Markdown
Contributor Author

kmoza commented Jun 30, 2019

@Mariatta I have submitted my signed CLA today and tried to check the status of my CLA at https://check-python-cla.herokuapp.com/. However, the response from https://check-python-cla.herokuapp.com/ is "has not signed CLA" for my Github username. Could you help whether I am missing something or the status will be updated after a day.

@Mariatta
Copy link
Copy Markdown
Member

Mariatta commented Jun 30, 2019

CLA tales one business day to process. Please check again tomorrow. Thanks.

Mariatta
Mariatta approved these changes Jun 30, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mariatta Mariatta changed the title bpo-36168: fixed case for get_value doc bpo-36168: Lowercase the word "subsequent" in get_value doc Jun 30, 2019
@Mariatta
Copy link
Copy Markdown
Member

Mariatta commented Jun 30, 2019

Thanks and congrats for your first contribution to CPython 🌮
This will be automatically merged once we receive the CLA. Please re-check the CLA in a day.

@miss-islington miss-islington merged commit 12b436e into python:master Jul 1, 2019
@CuriousLearner
Copy link
Copy Markdown
Member

CuriousLearner commented Jul 1, 2019

Hey @Mariatta

This also needs a backport to 3.8 labels as per the issue.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 1, 2019

Thanks @kmoza for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 1, 2019

GH-14519 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2019
@kmoza @miss-islington
bpo-36168: Lowercase the word "subsequent" in get_value doc (pythonGH…
87b8e92 
…-14485)

Subsequent -> subsequent

https://bugs.python.org/issue36168
(cherry picked from commit 12b436e)

Co-authored-by: Krishna Oza <krishoza15sep@gmail.com>
miss-islington added a commit that referenced this pull request Jul 1, 2019
@miss-islington @kmoza
bpo-36168: Lowercase the word "subsequent" in get_value doc (GH-14485)
59ec9ee 
Subsequent -> subsequent

https://bugs.python.org/issue36168
(cherry picked from commit 12b436e)

Co-authored-by: Krishna Oza <krishoza15sep@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@kmoza @lisroach
bpo-36168: Lowercase the word "subsequent" in get_value doc (pythonGH…
d895e38 
…-14485)

Subsequent -> subsequent

https://bugs.python.org/issue36168
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@kmoza @DinoV
bpo-36168: Lowercase the word "subsequent" in get_value doc (pythonGH…
f2c897c 
…-14485)

Subsequent -> subsequent

https://bugs.python.org/issue36168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kmoza @the-knights-who-say-ni @Mariatta @CuriousLearner @miss-islington @bedevere-bot