bpo-10945: Drop support for bdist_wininst on non-Windows systems#14506

hroncok · 2019-07-01T10:46:48Z

bdist_wininst depends on MBCS codec, unavailable on non-Windows,
and bdist_wininst have not worked since at least Python 3.2, possibly
never on py3k.

Here we document that bdist_wininst is only supported on Windows
and we mark it _unsupported otherwise to skip tests.

Distributors of Python 3 can now safely drop the bdist_wininst .exe files
without the need to skip bdist_wininst related tests.

https://bugs.python.org/issue10945

bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on py3k. Here we document that bdist_wininst is only supported on Windows and we mark it _unsupported otherwise to skip tests. Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests.

vstinner · 2019-07-01T10:58:40Z

Doc/distutils/builtdist.rst

 The installer file will be written to the "distribution directory" --- normally
 :file:`dist/`, but customizable with the :option:`!--dist-dir` option.

+   .. versionchanged:: 3.9


Please remove this note.

I don't see why this change should be Python 3.9 only: mbcs encoding was never available on platforms other than Windows. If we make a change, I suggest to make it in 3.7, 3.8 and master branches.

Gladly 🚀

vstinner · 2019-07-01T11:00:09Z

Lib/distutils/command/bdist_wininst.py

    boolean_options = ['keep-temp', 'no-target-compile', 'no-target-optimize',
                       'skip-build']

+    _unsupported = platform.system() != "Windows"


I suggest:

# bpo-10945: bdist_wininst requires mbcs encoding which is only available on Windows _unsupported = (sys.platform != "win32")

vstinner · 2019-07-01T11:00:52Z

Misc/NEWS.d/next/Windows/2019-07-01-12-38-48.bpo-10945.s0YBHG.rst

@@ -0,0 +1,2 @@
+Officially drop support for creating bdist_wininst installers on non-Windows
+systems.


Technically, it wasn't supported previously, so I don't think that we even have to document the change. But I'm fine with keeping this changelog entry if you prefer.

bedevere-bot · 2019-07-01T11:01:00Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

hroncok · 2019-07-01T11:10:44Z

I have made the requested changes; please review again

bedevere-bot · 2019-07-01T11:10:47Z

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

hroncok · 2019-07-01T11:11:09Z

An idea: Don't install the relevant exe files on non-Windows?

Lib/distutils/command/bdist_wininst.py

Doc/distutils/builtdist.rst

vstinner · 2019-07-01T11:14:16Z

An idea: Don't install the relevant exe files on non-Windows?

I would prefer to have a separated PR for that.

vstinner

LGTM. Thanks for the update.

miss-islington · 2019-07-01T12:12:43Z

Thanks @hroncok for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington · 2019-07-01T12:12:44Z

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

…honGH-14506) bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3. Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests. Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests. (cherry picked from commit 72cd653) Co-authored-by: Miro Hrončok <miro@hroncok.cz>

bedevere-bot · 2019-07-01T12:12:55Z

GH-14509 is a backport of this pull request to the 3.7 branch.

miss-islington · 2019-07-01T12:13:02Z

Thanks @hroncok for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

…honGH-14506) bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3. Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests. Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests. (cherry picked from commit 72cd653) Co-authored-by: Miro Hrončok <miro@hroncok.cz>

bedevere-bot · 2019-07-01T12:13:13Z

GH-14510 is a backport of this pull request to the 3.8 branch.

…14506) bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3. Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests. Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests. (cherry picked from commit 72cd653) Co-authored-by: Miro Hrončok <miro@hroncok.cz>

…honGH-14506) bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3. Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests. Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests.

the-knights-who-say-ni added the CLA signed label Jul 1, 2019

bedevere-bot added the awaiting review label Jul 1, 2019

vstinner requested changes Jul 1, 2019

View reviewed changes

bedevere-bot removed the awaiting review label Jul 1, 2019

bedevere-bot added the awaiting changes label Jul 1, 2019

hroncok added 2 commits July 1, 2019 13:03

fixup! bpo-10945: Drop support for bdist_wininst on non-Windows systems

cf0cbb0

fixup! bpo-10945: Drop support for bdist_wininst on non-Windows systems

11137fc

bedevere-bot added awaiting change review and removed awaiting changes labels Jul 1, 2019

vstinner reviewed Jul 1, 2019

View reviewed changes

Lib/distutils/command/bdist_wininst.py Outdated Show resolved Hide resolved

vstinner reviewed Jul 1, 2019

View reviewed changes

Doc/distutils/builtdist.rst Show resolved Hide resolved

fixup! bpo-10945: Drop support for bdist_wininst on non-Windows systems

8f4e424

vstinner added needs backport to 3.7 labels Jul 1, 2019

vstinner approved these changes Jul 1, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Jul 1, 2019

vstinner merged commit 72cd653 into python:master Jul 1, 2019

bedevere-bot removed the awaiting merge label Jul 1, 2019

vstinner removed the needs backport to 3.8 label Jul 1, 2019

bedevere-bot removed the needs backport to 3.7 label Jul 1, 2019

vstinner added the needs backport to 3.8 label Jul 1, 2019

bedevere-bot removed the needs backport to 3.8 label Jul 1, 2019

hroncok deleted the no_bdist_wininst_on_nonwin branch July 1, 2019 12:13

		@@ -0,0 +1,2 @@
		Officially drop support for creating bdist_wininst installers on non-Windows
		systems.

Uh oh!

Conversation

hroncok commented Jul 1, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner Jul 1, 2019

Choose a reason for hiding this comment

Uh oh!

hroncok Jul 1, 2019

Choose a reason for hiding this comment

Uh oh!

vstinner Jul 1, 2019

Choose a reason for hiding this comment

Uh oh!

vstinner Jul 1, 2019

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Jul 1, 2019

Uh oh!

hroncok commented Jul 1, 2019

Uh oh!

bedevere-bot commented Jul 1, 2019

Uh oh!

hroncok commented Jul 1, 2019

Uh oh!

Uh oh!

Uh oh!

vstinner commented Jul 1, 2019

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Jul 1, 2019

Uh oh!

miss-islington commented Jul 1, 2019

Uh oh!

bedevere-bot commented Jul 1, 2019

Uh oh!

miss-islington commented Jul 1, 2019

Uh oh!

bedevere-bot commented Jul 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hroncok commented Jul 1, 2019 •

edited by bedevere-bot

Loading