Skip to content

bpo-18049: Define THREAD_STACK_SIZE for AIX to pass default recursion limit test#15081

Merged
ronaldoussoren merged 2 commits intopython:masterfrom
aixtools:bpo-18049-stack-size
Aug 3, 2019
Merged

bpo-18049: Define THREAD_STACK_SIZE for AIX to pass default recursion limit test#15081
ronaldoussoren merged 2 commits intopython:masterfrom
aixtools:bpo-18049-stack-size

Conversation

@aixtools
Copy link
Copy Markdown
Contributor

@aixtools aixtools commented Aug 2, 2019 •
edited by bedevere-bot
Loading

@aixtools
Copy link
Copy Markdown
Contributor Author

aixtools commented Aug 2, 2019 •
edited
Loading

Still needs some adjustment - test_queue now fails with default memory size...

With new size (0x200000) both test_threading and test_queue pass.

Ready for review (@ronaldoussoren please review)

ronaldoussoren
ronaldoussoren approved these changes Aug 2, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good to me.

Thank you for the patch.

@ronaldoussoren ronaldoussoren merged commit 9670ce7 into python:master Aug 3, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 3, 2019

Thanks @aixtools for the PR, and @ronaldoussoren for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 3, 2019

Sorry @aixtools and @ronaldoussoren, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 9670ce76b83bde950020f8d89c4d27168aaaf912 3.8

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 3, 2019

Thanks @aixtools for the PR, and @ronaldoussoren for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2019
@aixtools @miss-islington
bpo-18049: Define THREAD_STACK_SIZE for AIX to pass default recursion…
9f83174 
… limit test (pythonGH-15081)

* Define THREAD_STACK_SIZE for AIX to pass default recursion limit test
(cherry picked from commit 9670ce7)

Co-authored-by: Michael Felt <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 3, 2019

GH-15089 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 29, 2019

Thanks @aixtools for the PR, and @ronaldoussoren for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2019
@aixtools @miss-islington
bpo-18049: Define THREAD_STACK_SIZE for AIX to pass default recursion…
4bf9ec2 
… limit test (pythonGH-15081)

* Define THREAD_STACK_SIZE for AIX to pass default recursion limit test
(cherry picked from commit 9670ce7)

Co-authored-by: Michael Felt <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 29, 2019

GH-15572 is a backport of this pull request to the 3.8 branch.

@ned-deily
Copy link
Copy Markdown
Member

ned-deily commented Aug 29, 2019

(Original 3.8 backport (GH-15089) failed due to remote server problem; retrying backport in GH-15572.)

miss-islington added a commit that referenced this pull request Aug 29, 2019
@miss-islington @aixtools
bpo-18049: Define THREAD_STACK_SIZE for AIX to pass default recursion…
f92bb6e 
… limit test (GH-15081)

* Define THREAD_STACK_SIZE for AIX to pass default recursion limit test
(cherry picked from commit 9670ce7)

Co-authored-by: Michael Felt <[email protected]>
@aeros aeros mentioned this pull request Sep 3, 2019
Merged
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@aixtools @lisroach
bpo-18049: Define THREAD_STACK_SIZE for AIX to pass default recursion…
b5c58e1 
… limit test (pythonGH-15081)

* Define THREAD_STACK_SIZE for AIX to pass default recursion limit test
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@aixtools @DinoV
bpo-18049: Define THREAD_STACK_SIZE for AIX to pass default recursion…
1db4e04 
… limit test (pythonGH-15081)

* Define THREAD_STACK_SIZE for AIX to pass default recursion limit test
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@aixtools @websurfer5
bpo-18049: Define THREAD_STACK_SIZE for AIX to pass default recursion…
9239f6f 
… limit test (pythonGH-15081)

* Define THREAD_STACK_SIZE for AIX to pass default recursion limit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren approved these changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ronaldoussoren ronaldoussoren

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aixtools @miss-islington @bedevere-bot @ned-deily @ronaldoussoren @eamanu @the-knights-who-say-ni