Skip to content

Correct minor grammatical mistake in open()#15865

Merged
gpshead merged 1 commit intopython:masterfrom
andresdelfino:patch-1
Sep 10, 2019
Merged

Correct minor grammatical mistake in open()#15865
gpshead merged 1 commit intopython:masterfrom
andresdelfino:patch-1

Conversation

@andresdelfino
Copy link
Copy Markdown
Contributor

@andresdelfino andresdelfino commented Sep 10, 2019

Sorry, my mistake.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 10, 2019
@gpshead gpshead merged commit 0518451 into python:master Sep 10, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 10, 2019

Thanks @andresdelfino for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 10, 2019

Sorry, @andresdelfino and @gpshead, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 05184515f924c3880067aad87940dd466f751585 3.8

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 10, 2019

Sorry @andresdelfino and @gpshead, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 05184515f924c3880067aad87940dd466f751585 3.7

@andresdelfino andresdelfino deleted the patch-1 branch September 10, 2019 14:50
@andresdelfino
Copy link
Copy Markdown
Contributor Author

andresdelfino commented Sep 10, 2019

@gpshead #11314 was not backported to 3.7/3.8. Perhaps this shouldn't either?

@gpshead
Copy link
Copy Markdown
Member

gpshead commented Sep 10, 2019

I've kickedoff a backport of that to 3.8, once lands i'll bump this one to have our bot do the same.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 10, 2019

Thanks @andresdelfino for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
@andresdelfino @miss-islington
Correct minor grammatical mistake in open docs (pythonGH-15865)
0820ea7 
(cherry picked from commit 0518451)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 10, 2019

GH-15870 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 10, 2019
@miss-islington @andresdelfino
Correct minor grammatical mistake in open docs (GH-15865)
30a8fd7 
(cherry picked from commit 0518451)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@andresdelfino @websurfer5
Correct minor grammatical mistake in open docs (pythonGH-15865)
b7f147d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@gpshead gpshead

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andresdelfino @miss-islington @gpshead @bedevere-bot @the-knights-who-say-ni