bpo-37363: Add audit events to the http.client module#21321
Merged
matrixise merged 4 commits intopython:masterfrom Apr 23, 2021
Merged
bpo-37363: Add audit events to the http.client module#21321matrixise merged 4 commits intopython:masterfrom
http.client module#21321matrixise merged 4 commits intopython:masterfrom
Conversation
Member
|
Hello @gousaiyang Thank you for your contribution, really appreciated. Could you add some tests, for example, you could check in |
Contributor
Author
|
Hi @matrixise. If you had time could you review this PR again? Thanks! |
gousaiyang
force-pushed
the
audit-http-client
branch
from
03d5cfc to
7b23cbc
Compare
Member
|
Hi @gousaiyang Your PR is on my list. I will check it asap. Thank you |
Member
|
Just forgot to approve the branch, but everything seems fine to me. @gousaiyang Thank you for your contribution, this one will be only in 3.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37363