Merged
Conversation
Contributor
|
Adding buildbot tests as meddling with global state usually causes refleaks or environment change failures. |
Member
Author
|
Is it related? |
Contributor
|
This is indeed unrelated, Nikita. It's fixed by GH-29382 already. |
Contributor
Contributor
|
Sorry, @sobolevn and @ambv, I could not cleanly backport this to |
Contributor
|
Sorry @sobolevn and @ambv, I had trouble checking out the |
|
GH-29385 is a backport of this pull request to the 3.10 branch. |
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Nov 3, 2021
(cherry picked from commit e346f19) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Nov 3, 2021
(cherry picked from commit e346f19) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-29386 is a backport of this pull request to the 3.9 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR for this issue (I plan to make the second one with
dis.findlabelstests).https://bugs.python.org/issue45578