Skip to content

bpo-46422: use dis.Positions in dis.Instruction#30716

Merged
isidentical merged 6 commits intopython:mainfrom
sobolevn:issue-46422
Jan 24, 2022
Merged

bpo-46422: use dis.Positions in dis.Instruction#30716
isidentical merged 6 commits intopython:mainfrom
sobolevn:issue-46422

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented Jan 20, 2022 •
edited by bedevere-bot
Loading

@sobolevn sobolevn requested a review from isidentical January 20, 2022 07:37
isidentical
isidentical requested changes Jan 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sobolevn!

  • The tests only seem to cover cases where the code object is missing one of the position tables. Let's add a test like test_co_positions which uses the new positions API.
  • Let's also document the new API

Lib/dis.py Outdated
positions = next(co_positions)
positions = Positions(*next(co_positions))
except StopIteration:
positions = None
Copy link
Copy Markdown
Member

@isidentical isidentical Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simply create an empty Positions() object here.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jan 20, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Jan 20, 2022 •
edited
Loading

Thanks for the feedback! I've added docs about position field, but I didn't cover Positions namedtuple explicitly. I hope that reference to some "namedtuple" is good enough. But, I can fix it if needed 🙂

I have made the requested changes; please review again.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jan 20, 2022

Thanks for making the requested changes!

@isidentical: please review the changes made to this pull request.

isidentical
isidentical approved these changes Jan 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I think it looks good as is but let's clear the documentation a bit.

isidentical
isidentical approved these changes Jan 24, 2022
View reviewed changes
@isidentical
Copy link
Copy Markdown
Member

isidentical commented Jan 24, 2022

Azure is weirdly failing 🤦🏻 Closing/Re-opening to restart.

@isidentical isidentical reopened this Jan 24, 2022
@isidentical isidentical merged commit 58f3d98 into python:main Jan 24, 2022
@isidentical
Copy link
Copy Markdown
Member

isidentical commented Jan 24, 2022

Thanks very much for noticing (and fixing) this @sobolevn!

@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Jan 24, 2022

Thanks for the review! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isidentical isidentical isidentical approved these changes

+1 more reviewer

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @bedevere-bot @isidentical @raghavthind2005 @the-knights-who-say-ni