Build libbacktrace with mmapio.c instead of read.c#298
Build libbacktrace with mmapio.c instead of read.c#298alexcrichton merged 1 commit intorust-lang:masterfrom
Conversation
|
It looks like Windows may need to be exempted and continue to use the older implementation? |
|
@alexcrichton: At this point, we might want to just switch to using the Do you have a strong preference for the current approach of hardcoding the relevant paths into |
|
Having maintained running the configure script for years, yes I have quite a strong preference for never going back to that. It's ok if you label it "hacky" but I would personally label it "vastly more reliable than anything we had before" from my experience. I would be fine with writing down "if windows compile this file, else that file" |
|
@alexcrichton: Fair enough - I'll add an explicit check for Windows. |
Fixes rust-lang#289 `mmap` should be available on all platforms we support (except Windows), so we can use `libbacktrace`'s more efficient mmap-based code.
96d281b to
17ab01b
Compare
|
@alexcrichton: Updated |
|
Thanks! |
Fixes #289
mmapshould be available on all platforms we support, so we can uselibbacktrace's more efficient mmap-based code.