Skip to content

Tweeks to proptests#6599

Merged
bors merged 3 commits intorust-lang:masterfrom
Eh2406:more-tests
Jan 25, 2019
Merged

Tweeks to proptests#6599
bors merged 3 commits intorust-lang:masterfrom
Eh2406:more-tests

Conversation

@Eh2406
Copy link
Copy Markdown
Contributor

@Eh2406 Eh2406 commented Jan 25, 2019

This is some small tweaks to the prop test configuration and adds an additional test.

Most of the diff is whitespace.

@rust-highfive
Copy link
Copy Markdown

r? @dwijnand

(rust_highfive has picked a reviewer for you, use r? to override)

@dwijnand
Copy link
Copy Markdown
Contributor

Failure for Rust 1.31.0:

---- support::resolver::meta_test_multiple_versions_strategy stdout ----
thread 'support::resolver::meta_test_multiple_versions_strategy' panicked at 'In 1280 tries we did not see a wide enough distribution of multiple versions of the same library! dis: [1099, 45, 31, 16, 20, 15, 3, 3, 0, 9]', tests/testsuite/support/resolver.rs:564:5

I'll assume it's spurious.

LGTM, enabling caching there looks like a good change.

@bors: r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Jan 25, 2019

📌 Commit d9e6360 has been approved by dwijnand

@bors
Copy link
Copy Markdown
Contributor

bors commented Jan 25, 2019

⌛ Testing commit d9e6360 with merge 1b716f6...

bors added a commit that referenced this pull request Jan 25, 2019
Tweeks to proptests

This is some small tweaks to the prop test configuration and adds an additional test.

Most of the diff is whitespace.
@bors
Copy link
Copy Markdown
Contributor

bors commented Jan 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: dwijnand
Pushing 1b716f6 to master...

@bors bors merged commit d9e6360 into rust-lang:master Jan 25, 2019
@Eh2406 Eh2406 deleted the more-tests branch January 28, 2019 16:52
@ehuss ehuss added this to the 1.34.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants