Fix bug when with resolver = "1" non-virtual package was allowing unknown features

[In-line]

No description provided.

[In-line]

I accidently found, that if I remove resolver = "2" from this test if fails. It seems that doing cargo build --features package_name/some-nonsense is acceptable by cargo

[In-line]

Output with cargo ea0b5ca

thread 'package_features::virtual_typo_member_feature_default_resolver' panicked at '
Expected: execs
    but: differences:
  0 - |[ERROR] none of the selected packages contains these features: a/deny-warning|
    + |error: package `a v0.1.0 (/home/alik/Documents/projects/cargo/target/cit/t0/foo)` does not have a dependency named `a`|

But with d087aeb

thread 'package_features::virtual_typo_member_feature_default_resolver' panicked at '
Expected: execs
    but: exited with exit code: 0
--- stdout

--- stderr

[ehuss]

Hm, looks like that slipped through. Would you be interested in trying to fix it?

[In-line]

@ehuss I will be looking to it.

[In-line]

r? @ehuss

[ehuss]

Hm, so I'm a bit uncertain about the approach here. If I understand correctly, the main concern is that with --features foo/featname, and foo is the "current" package, then featname is more or less ignored. Would it be possible to change it so that in that scenario, the feature is added to cwd_features instead? That should pass the feature to the normal machinery for checking if the feature exists. Then, the check for !member_specific_features.is_empty() can be treated more as a bug, since the two loops should end up matching one another.

[In-line]

@ehuss do you have any more ideas for test cases?

[ehuss]

Thanks!

I think the tests are good enough, I can't think of anything specific to check.

I pushed a small change to remove masquerade_as_nightly_cargo which wasn't needed (it was an accident it wasn't removed in the other test).

@bors r+

[bors]

📌 Commit 61b762b has been approved by ehuss

[bors]

⌛ Testing commit 61b762b with merge 07340c9...

[bors]

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 07340c9 to master...