i128 intrinsics#133

est31 · 2017-01-04T02:10:24Z

Adds i128 intrinsics.

Note that this PR doesn't do float intrinsics, due to the missing presence of macros, those are however still required in order for rustc to switch to this crate.

est31 · 2017-01-04T02:14:52Z

Builds fail because they are still on an outdated nightly (in fact, nightly with i128 support is released yet).

I'm currently only developing with RUSTFLAGS="--cfg stage0" cargo test --no-default-features, and after nightlies will be available, I'll drop the RUSTFLAGS argument.

est31 · 2017-01-05T14:27:30Z

Now still to do: a) unit tests b) better stage0 support. Then I'm ready for review :)

est31 · 2017-01-06T06:24:56Z

Okay, I think adding tests is a little bit complicated, as the tests will only work on 64 bit non windows platforms... Is it okay if this doesn't get quickcheck like tests for now? if yes, r? @japaric

est31 · 2017-02-03T23:08:31Z

@japaric I've added quickcheck tests. r?

japaric · 2017-02-04T00:27:54Z

+            let mut overflow = 2;
+            let r = f(a, b, &mut overflow);
+            if overflow != 0 && overflow != 1 {
+                return None


wouldn't a value different that 0 or 1 indicate a bug in our implementation? I think such case should panic instead of being skipped.

japaric · 2017-02-04T00:28:17Z

+            if d == 0 {
+                None
+            } else {
+                // FIXME fix the segfault when the remainder is requested


Could you open an issue about this?

japaric · 2017-02-04T00:29:51Z

Thanks, @est31. r=me with with the overflow change.

est31 · 2017-02-04T00:40:08Z

Changed it. Note that travis failed due to bug #136.

japaric · 2017-02-04T01:01:59Z

Changed it. Note that travis failed due to bug #136.

That should be fixed in #138 so I'm going to put this in the queue.

@bors r+

bors · 2017-02-04T01:01:59Z

📌 Commit f8a4e3f has been approved by japaric

bors · 2017-02-04T03:36:30Z

⌛ Testing commit f8a4e3f with merge ca6bb63...

i128 intrinsics Adds i128 intrinsics. Note that this PR doesn't do float intrinsics, due to the missing presence of macros, those are however still required in order for rustc to switch to this crate.

bors · 2017-02-04T04:54:10Z

💔 Test failed - status-travis

japaric · 2017-02-04T04:54:15Z

I have manually cleared the caches. Let's try again.

@bors retry

bors · 2017-02-04T04:54:20Z

⌛ Testing commit f8a4e3f with merge 547b938...

i128 intrinsics Adds i128 intrinsics. Note that this PR doesn't do float intrinsics, due to the missing presence of macros, those are however still required in order for rustc to switch to this crate.

est31 · 2017-02-04T05:36:01Z

hmm seems that mips64-unknown-linux-gnuabi64 and mips64el-unknown-linux-gnuabi64 tests failed for __modti3 and __divti3:

__divti3 - Args: 119123594998676976834373841781095175696 75802332446715572479975239465689939968 
 compiler-builtins: Some(-102509915410633448775648222814998102015)
 compiler_rt:       Some(1)
 gcc_s:             Some(Some(1))
__divti3 - Args: 59561797499338488417186920890547587848 75802332446715572479975239465689939968 

 compiler-builtins: Some(-51254957705316724387824111407499051008)
 compiler_rt:       Some(0)
 gcc_s:             Some(Some(0))

and

__modti3 - Args: 27708956818918212506987268272516826162 322710947762631927081672291152409133056 
 compiler-builtins: Some(10137537660611676125284951993157747760)
 compiler_rt:       Some(10137537660611676125284951993157747762)
 gcc_s:             Some(Some(10137537660611676125284951993157747762))
__modti3 - Args: 13854478409459106253493634136258413081 322710947762631927081672291152409133056 
 compiler-builtins: Some(13854478409459106253493634136258413080)
 compiler_rt:       Some(13854478409459106253493634136258413081)
 gcc_s:             Some(Some(13854478409459106253493634136258413081))

bors · 2017-02-04T05:55:56Z

💔 Test failed - status-travis

est31 · 2017-02-04T11:10:08Z

Well seems mips does not support i128 integers on clang, which means we should disable it anyway. Will disable all quickcheck tests for mips.

est31 · 2017-02-04T11:21:56Z

r? @japaric

Two reasons: * the C versions __divti3 and __modti3 are apparently broken, at least when used in quickcheck. They change their own arguments. * compiler_rt's support for mips is disabled already on clang [1]. Its desireable to support working "cargo test" on that compiler as well, and not greet the tester with linker errors. [1]: http://llvm.org/viewvc/llvm-project?view=revision&revision=224488

japaric · 2017-02-04T13:22:48Z

@bors r+

bors · 2017-02-04T13:22:49Z

📌 Commit 37d3490 has been approved by japaric

bors · 2017-02-04T13:22:54Z

⌛ Testing commit 37d3490 with merge 9debde0...

i128 intrinsics Adds i128 intrinsics. Note that this PR doesn't do float intrinsics, due to the missing presence of macros, those are however still required in order for rustc to switch to this crate.

bors · 2017-02-04T13:42:52Z

☀️ Test successful - status-appveyor, status-travis
Approved by: japaric
Pushing 9debde0 to master...

est31 force-pushed the i128 branch 9 times, most recently from ae515d0 to d053642 Compare January 5, 2017 11:00

est31 mentioned this pull request Jan 5, 2017

rust-lang/rust integration metabug #66

Closed

8 tasks

est31 force-pushed the i128 branch from c8e2cfe to f97d616 Compare January 5, 2017 14:26

est31 force-pushed the i128 branch 5 times, most recently from c6cc332 to d3b0497 Compare January 6, 2017 06:03

est31 force-pushed the i128 branch from d3b0497 to 483d558 Compare January 6, 2017 06:34

est31 changed the title ~~[wip] i128 intrinsics~~ i128 intrinsics Jan 6, 2017

est31 mentioned this pull request Jan 17, 2017

move to the WIP Rust port of compiler-rt rust-lang/rust#37802

Closed

est31 added 6 commits February 2, 2017 21:27

Add i128 to lib.rs as feature

a2e2ec1

int module: macro-ify trait impls and add {u,i}128 support

b356429

i128 mul intrinsics

3055aa2

i128 shift intrinsics

1e27c3f

Macro-ify udivmod

8fe50d8

u128 udiv intrinsics

2f3c534

est31 force-pushed the i128 branch from 483d558 to b6063bc Compare February 2, 2017 21:13

u128 sdiv intrinsics

9013dbe

est31 force-pushed the i128 branch 2 times, most recently from e9d01fb to b78e956 Compare February 3, 2017 22:46

Add quickcheck tests

b78e956

japaric reviewed Feb 4, 2017

View reviewed changes

Panic when invalid overflow value is returned

f8a4e3f

est31 mentioned this pull request Feb 4, 2017

Segfault in __udivmodti4 quickcheck when remainder is requested #137

Closed

est31 force-pushed the i128 branch from 7832af9 to 37d3490 Compare February 4, 2017 11:23

bors merged commit 37d3490 into rust-lang:master Feb 4, 2017

Conversation

est31 commented Jan 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

est31 commented Jan 4, 2017

Uh oh!

est31 commented Jan 5, 2017

Uh oh!

est31 commented Jan 6, 2017

Uh oh!

est31 commented Feb 3, 2017

Uh oh!

japaric Feb 4, 2017

Choose a reason for hiding this comment

Uh oh!

japaric Feb 4, 2017

Choose a reason for hiding this comment

Uh oh!

est31 Feb 4, 2017

Choose a reason for hiding this comment

Uh oh!

japaric commented Feb 4, 2017

Uh oh!

est31 commented Feb 4, 2017

Uh oh!

japaric commented Feb 4, 2017

Uh oh!

bors commented Feb 4, 2017

Uh oh!

bors commented Feb 4, 2017

Uh oh!

bors commented Feb 4, 2017

Uh oh!

japaric commented Feb 4, 2017

Uh oh!

bors commented Feb 4, 2017

Uh oh!

est31 commented Feb 4, 2017

Uh oh!

bors commented Feb 4, 2017

Uh oh!

est31 commented Feb 4, 2017

Uh oh!

est31 commented Feb 4, 2017

Uh oh!

japaric commented Feb 4, 2017

Uh oh!

bors commented Feb 4, 2017

Uh oh!

bors commented Feb 4, 2017

Uh oh!

bors commented Feb 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

est31 commented Jan 4, 2017 •

edited

Loading