support building Miri outside a git repo#1798
Merged
bors merged 1 commit intorust-lang:masterfrom May 15, 2021
Merged
Conversation
Member
Author
|
Judging from this, rustc seems to fall back to just omitting the git info when it cannot be obtained. So I changed Miri to do the same. |
oli-obk
approved these changes
May 15, 2021
Member
Author
|
@bors r=oli-obk |
Contributor
|
📌 Commit 64f128c has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
|
@RalfJung thanks !
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/rust#84182
@semarie this should fix your problem... but I think any version of Miri actually shipped to users should have the proper git version information embedded, so I am not sure if this is the right fix. How do you do this for rustc proper? Even stable builds usually have a git version: