-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
bootstrap PGO artifact copies broken #113784
Copy link
Copy link
Closed
Labels
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Milestone
Metadata
Metadata
Assignees
Labels
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Type
Fields
Give feedbackNo fields configured for issues without a type.
It looks like at least the old Python script hardcoded the channel as "nightly", which won't work on beta and stable branches.
27ff819 fixed this for last week's promotion from master -> beta, but it won't work on beta -> stable as that has yet another format.
We probably want to mirror the logic here: https://github.com/rust-lang/promote-release/blob/348f02569e3aff02187e90bbf532e63ccf62a268/src/main.rs#L451-L458, specifically the version part.
I think we'll want to land a commit on beta with the fix targeting stable, and a separate one on master -- given we just rewrote the script to Rust I'm not sure trying to backport something makes much sense. If the beta commit is tricky for some reason, we can skip that and just hardcode the version when running the next beta -> stable promotion.
cc @Kobzol -- maybe you can help work on this.