deadlock ice: missing thread name

[matthiaskrgr]

I noticed that when parallel rustc panics due to deadlock, it would say thread 'unnamed' panicked instead of thread 'rustc' panicked.

Is this intended?

[ChrisDenton]

Hm, I did recently land a related std change but I'm not sure if it would cause this issue. It should only affect threads that Rust doesn't create itself and in any case it switches the default name from None (which gets rendered as <unnamed>) to the OS thread name (if available). So if anything I'd have thought it would have the opposite effect.

Though maybe there's something about parallel's deadlocks I'm missing.

[matthiaskrgr]

I think you're good since the problem is older than your pr :D
#120759

[ChrisDenton]

Oh good! I mean bad, but I was dreading a very long debugging session 😆

[matthiaskrgr]

well, if you feel bored or something.... 🙃

[Noratrieb]

Serial rustc creates a single thread called rustc. I assume parallel rustc just doesn't name its rayon threads, no debugging session ahead.

[Zoxc]

We create a new thread to look for query cycles, it's unnamed at the moment and that's where the panic happens.