Tracking Issue for `non_null_from_ref`

[bjoernager]

Feature gate: #![feature(non_null_from_ref)]

This is a tracking issue for adding the convenience constructors from_ref and from_mut to core::ptr::NonNull.

Public API

// core::ptr

impl<T: ?Sized> NonNull<T> {
    pub const fn from_ref(r: &T) -> Self;

    pub const fn from_mut(r: &mut T) -> Self;
}

Steps / History

• API change proposal (ACP): #448
• Implementation: Add from_ref and from_mut constructors to core::ptr::NonNull. #130822
• Final comment period (FCP)
• Stabilization PR: Stabilize #![feature(non_null_from_ref)] #140511

Unresolved Questions

• None yet.

[smalis-msft]

Is there anything blocking these from stabilization? They seem pretty straightforward.

[bjoernager]

Nope, nothing that I'm aware of (other than the FCP).

[m-ou-se]

@rfcbot merge

[rfcbot]

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @BurntSushi
• @dtolnay
• @joshtriplett
• @m-ou-se

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.