-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
cargo fix doesn't apply fixes it suggests #142998
Copy link
Copy link
Closed
Labels
A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.Area: Lints (warnings about flaws in source code) such as unused_mut.A-suggestion-diagnosticsArea: Suggestions generated by the compiler applied by `cargo fix`Area: Suggestions generated by the compiler applied by `cargo fix`L-mismatched_lifetime_syntaxesLint: mismatched_lifetime_syntaxesLint: mismatched_lifetime_syntaxesT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.Area: Lints (warnings about flaws in source code) such as unused_mut.A-suggestion-diagnosticsArea: Suggestions generated by the compiler applied by `cargo fix`Area: Suggestions generated by the compiler applied by `cargo fix`L-mismatched_lifetime_syntaxesLint: mismatched_lifetime_syntaxesLint: mismatched_lifetime_syntaxesT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
When running
cargo fix(or any cargo command, really) it often ends with this message:However, doing so does not appear to actually apply any fixes. In fact, the above message came about as a result of running
cargo fix.I tried this code:
git clone --depth 1 --revision abbf996695d645b81a046b9451544a15a8bfeb27 https://github.com/probe-rs/probe-rs.git cd probe-rs cargo +nightly fixI expected to see this happen: The lifetime warnings mentioned should be fixed
Instead, this happened: The repository is unchanged
Meta
rustc +nightly --version --verbose: