-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
dvec and vec interface cleanup #2924
Copy link
Copy link
Closed
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Description
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Vec needs 'reach'. (fixed)
Dvec needs 'reverse'. (fixed)
Dvec 'reach' doesn't... reach. i.e., it iterates in fwd order. (fixed)
many should be pure that aren't (dvec len) (fixed)
dvec needs 'view' (didn't bother)
the fold* suite is really messy when constness doesn't match up - maybe have one for each constness? (didn't bother)
Found during ICFP (#2928).