-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
duplicated errors for invalid derives #34229
Copy link
Copy link
Closed
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.Call for participation: An issue has been fixed and does not reproduce, but no test has been added.
Metadata
Metadata
Assignees
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.Call for participation: An issue has been fixed and does not reproduce, but no test has been added.
Type
Fields
Give feedbackNo fields configured for issues without a type.
This code attempts to derive
PartialOrdin an invalid situation, and is rewarded with a barrage of duplicate errors:The error
the trait core::cmp::PartialOrd is not implemented for the type Comparableonly appears once. However, the errorbinary operation < cannot be applied to type Comparable(along with notean implementation of std::cmp::PartialOrd might be missing for Comparable... gee, really?) appears eight times, four for<and four for>.I assume this is because an error is generated at several points within the (invisible) generated
PartialOrdimplementation. But since they are all assigned the same span, maybe we can deduplicate.