-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
x.py fix #53896
Copy link
Copy link
Closed
Labels
C-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Description
Metadata
Metadata
Assignees
Labels
C-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
#53816 (migrating part of the codebase to use
'_lifetimes in type names) ended up involving quite a lot of manual text-editing labor because, unfortunately, rustfix doesn't work withx.py. (You might think that you could runcargo fixon an individual crate, but after supplying missing feature flags and environment variables (RUSTC_ERROR_METADATA_DST,CFG_COMPILER_HOST_TRIPLE), you end up triggering an assertion that I don't know how to hack around.) It would be nice if there was anx.py fixthat worked (even if the need won't come up very often).This issue should probably receive the A-rustbuild, C-feature-request, T-infra, and P-low labels.