-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
MutexGuard's Debug implementation is unuseful #57702
Copy link
Copy link
Closed
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
MutexGuard'sDebugimplementation just forwards to theMutex'sDebugimplementation, which will simply print<locked>, because theMutexwas locked (by that very sameMutexGuard).Effectively, this means that the current
Debugimplementation ofMutexGuardis equivalent to:Instead, it should not try to lock the mutex, but use its own
Derefimplementation to print the contents of the mutex.