Tracking Issue for `invalid_doc_attributes` lint

[Manishearth]

What is this lint about

The invalid_doc_attributes lint detects incorrect uses of #[doc(...)] attributes or uses of non-existent #[doc(...)] attributes. For example, #[doc(alias = 42)] will trigger this lint, since 42 is not a string. Also, #[doc(foobar)] will trigger this lint.

If you are here because of a warning about doc(primitive), see #88070 instead.

---

Original issue

From #82702: Currently the warning reuses the existing unknown_attributes lint, but to properly do future incompatibility we need to use the special infrastructure that exists for it.

We should also consider sticking this into the edition (see #80165), though I'm not sure if it can be automatically upgraded. This might be one of the cases where it doesn't matter.

[GuillaumeGomez]

I think the most important thing is to at least prevent non-functioning code to go unnoticed. So at least having warnings seems good enough. Then we can always discuss if we want to make it into a hard error or not when a new edition comes up.

[Manishearth]

Yep! I think using the future incompat architecture for this is great, because we can declare as early as possible that we're hoping to make this a hard error.

And then as things settle, someone can eventually have the proper discussion about how best to actually remove it.

[camelid]

It looks like this was implemented in #82708? Should we repurpose this as a tracking issue since it is linked to from the lint?

[Manishearth]

I believe that creates the lint but does not make it lint on all cases. That was written in the interest of fixing a nightly regression, so doesn't address the issue in this thread.

[camelid]

I believe that creates the lint but does not make it lint on all cases.

That lint is used for the unknown `doc` attribute warning:

rust/compiler/rustc_passes/src/check_attr.rs

Lines 588 to 599 in e7e1dc1

	self.tcx.struct_span_lint_hir(
	INVALID_DOC_ATTRIBUTES,
	hir_id,
	i_meta.span,
	|lint| {
	lint.build(&format!(
	"unknown `doc` attribute `{}`",
	i_meta.name_or_empty()
	))
	.emit();
	},
	);

and is thus future-incompat.