resolve: Extend `ambiguous_import_visibilities` deprecation lint to glob-vs-glob ambiguities#154149

petrochenkov · 2026-03-20T17:34:03Z

Continuation of #149596, implementation of this comment #149596 (comment) in particular.
FCP for the lint in general - #149596 (comment).
#152498 is reverted as a part of the change, but fixes are applied to keep the tests added in that PR working.

To implement this we have to have to track the most and the least visible declarations in an ambiguous glob set.

Part of #153961.
r? @yaahc maybe

petrochenkov · 2026-03-20T17:35:13Z

compiler/rustc_middle/src/middle/privacy.rs

+                        && let ItemKind::Use(_, UseKind::Glob) = item.kind
+                    {
+                        // Glob import visibilities can be increasee by other
+                        // more public glob imports in cases of ambiguity.


This is a fix for #151124.

petrochenkov · 2026-03-20T17:35:35Z

compiler/rustc_resolve/src/effective_visibilities.rs

            tcx,
        );
+        if let Some(max_vis_decl) = decl.ambiguity_vis_max.get() {
+            // Avoid the most visible import in an ambiguous glob set being reported as unused.


This is a fix for #152004.

petrochenkov · 2026-03-20T17:36:39Z

compiler/rustc_resolve/src/imports.rs


            if let Some(binding) = resolution.binding()
-                && old_decl != Some(binding)
+                && (old_decl != Some(binding) || old_vis != Some(binding.vis()))


And this is a fix for #152347.
Here we are triggering the glob re-fetching on visibility updates.

petrochenkov · 2026-03-20T17:52:58Z

@bors try

resolve: Extend `ambiguous_import_visibilities` deprecation lint to glob-vs-glob ambiguities

rust-bors · 2026-03-20T19:59:56Z

☀️ Try build successful (CI)
Build commit: 4907eac (4907eac94165faff6c5e5e015670b1c584275f7b, parent: bfc05d6b072585dfd0c792ec1b8728c08a3511fe)

petrochenkov · 2026-03-20T20:12:39Z

@craterbot check

craterbot · 2026-03-20T20:13:15Z

👌 Experiment pr-154149 created and queued.
🤖 Automatically detected try build 4907eac
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-03-28T10:24:52Z

🚧 Experiment pr-154149 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-03-30T08:16:36Z

🎉 Experiment pr-154149 is completed!
📊 136 regressed and 4 fixed (858234 total)
📊 5129 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-154149/retry-regressed-list.txt ↩

rustbot · 2026-04-10T16:21:32Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

petrochenkov · 2026-04-10T16:22:05Z

@bors try

resolve: Extend `ambiguous_import_visibilities` deprecation lint to glob-vs-glob ambiguities

petrochenkov · 2026-04-10T16:24:01Z

TODO: @craterbot run mode=check-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-154149/retry-regressed-list.txt

rust-log-analyzer · 2026-04-10T16:56:26Z

The job aarch64-gnu-llvm-21-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[endgroup]
Executing "/scripts/stage_2_test_set2.sh"
+ /scripts/stage_2_test_set2.sh
+ '[' 1 == 1 ']'
+ echo 'PR_CI_JOB set; skipping tidy'
+ SKIP_TIDY='--skip tidy'
+ ../x.py --stage 2 test --skip tidy --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest
PR_CI_JOB set; skipping tidy
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
---

test result: FAILED. 70 passed; 1 failed; 3 ignored; 0 measured; 0 filtered out; finished in 1.10s

all doctests ran in 3.09s; merged doctests compilation took 1.96s
error: doctest failed, to rerun pass `-p rustc_lint_defs --doc`
Bootstrap failed while executing `--stage 2 test --skip tidy --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Build completed unsuccessfully in 0:30:41
  local time: Fri Apr 10 16:56:14 UTC 2026
  network time: Fri, 10 Apr 2026 16:56:15 GMT
##[error]Process completed with exit code 1.

rust-bors · 2026-04-10T18:30:30Z

☀️ Try build successful (CI)
Build commit: fe84aa3 (fe84aa3583bb2681b5d0580316bde6d58ccfd6b5, parent: 8317fef20409adedaa7c385fa6e954867bf626fc)

petrochenkov · 2026-04-10T18:37:50Z

@craterbot run mode=check-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-154149/retry-regressed-list.txt

craterbot · 2026-04-10T18:37:58Z

👌 Experiment pr-154149-1 created and queued.
🤖 Automatically detected try build fe84aa3
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

petrochenkov · 2026-04-10T18:41:57Z

@craterbot p=11
This is a tiny run, and beta-1.95-5 is a full run.

craterbot · 2026-04-10T18:42:01Z

📝 Configuration of the pr-154149-1 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 20, 2026

rustbot assigned yaahc Mar 20, 2026

petrochenkov commented Mar 20, 2026

View reviewed changes

petrochenkov force-pushed the globvisglob branch from 171ed29 to 8c30e81 Compare March 20, 2026 17:52