Skip to content

Fix associated type bound suggestion span issue#154655

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
chenyukang:yukang-fix-145586-deserializer-bound-syntax
Apr 1, 2026
Merged

Fix associated type bound suggestion span issue#154655
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
chenyukang:yukang-fix-145586-deserializer-bound-syntax

Conversation

@chenyukang
Copy link
Copy Markdown
Member

@chenyukang chenyukang commented Apr 1, 2026 •
edited by rustbot
Loading

Fixes #145586

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 1, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 1, 2026

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 12 candidates

chenyukang
chenyukang commented Apr 1, 2026
View reviewed changes
Comment thread tests/ui/trait-bounds/deep-level-send-bound-check-issue-40827.stderr
@@ -1,5 +1,5 @@
error[E0277]: `Rc<Foo>` cannot be shared between threads safely
--> $DIR/deep-level-Send-bound-check-issue-40827.rs:14:7
--> $DIR/deep-level-send-bound-check-issue-40827.rs:14:7
Copy link
Copy Markdown
Member Author

@chenyukang chenyukang Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's weird to see uppercase in test file name, so fix it by the way.

jieyouxu
jieyouxu approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you can r=me once PR CI is green.
r? me

View changes since this review

@rustbot rustbot assigned jieyouxu and unassigned dingxiangfei2009 Apr 1, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang force-pushed the yukang-fix-145586-deserializer-bound-syntax branch from 8910047 to 50c6679 Compare April 1, 2026 02:12
@jieyouxu
Copy link
Copy Markdown
Member

jieyouxu commented Apr 1, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 1, 2026

📌 Commit 50c6679 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2026
@jhpratt jhpratt mentioned this pull request Apr 1, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Apr 1, 2026
@bors
Auto merge of #154668 - jhpratt:rollup-ePnl7Di, r=jhpratt
2bd7a97 
Rollup of 4 pull requests

Successful merges:

 - #154356 (    Add integer truncation and extension methods)
 - #154641 (build_helper: fix yarn locking, add check, and bump lockfile)
 - #154647 (change `c_double` to `f32` on `avr` targets)
 - #154655 (Fix associated type bound suggestion span issue)
chenyukang added a commit to chenyukang/rust that referenced this pull request Apr 1, 2026
@chenyukang
Rollup merge of rust-lang#154655 - chenyukang:yukang-fix-145586-deser…
63e9022 
…ializer-bound-syntax, r=jieyouxu

Fix associated type bound suggestion span issue

Fixes rust-lang#145586
@chenyukang chenyukang mentioned this pull request Apr 1, 2026
Closed
rust-timer added a commit that referenced this pull request Apr 1, 2026
@rust-timer
Unrolled build for #154655
f0f788e 
Rollup merge of #154655 - chenyukang:yukang-fix-145586-deserializer-bound-syntax, r=jieyouxu

Fix associated type bound suggestion span issue

Fixes #145586
@rust-bors rust-bors bot merged commit 7f794c3 into rust-lang:main Apr 1, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Invalid syntax suggested when trying to use serde::de::Deserializer<'de, Error = E>

5 participants

@chenyukang @rustbot @rust-log-analyzer @jieyouxu @dingxiangfei2009