Skip to content

Fix ICE in next-solver TransmuteFrom candidate#154991

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
cijiugechu:fix/next-solver-transmutefrom-ice
Apr 9, 2026
Merged

Fix ICE in next-solver TransmuteFrom candidate#154991
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
cijiugechu:fix/next-solver-transmutefrom-ice

Conversation

@cijiugechu
Copy link
Copy Markdown
Contributor

@cijiugechu cijiugechu commented Apr 8, 2026

Treat TransmuteFrom goals with non-region inference variables as ambiguous before running transmutability, matching the old solver.

Closes #153370 .

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Apr 8, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 8, 2026

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 9, 2026

r? me @bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 9, 2026

📌 Commit c3c154f has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2026
@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 9, 2026

@bors r-

@bors squash

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 9, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 9, 2026

🚧 Squashing... this can take a few minutes.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 9, 2026

❗ Failed to push the squashed commit to cijiugechu/rust:fix/next-solver-transmutefrom-ice: Push timeouted

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 9, 2026

can you please squash commits if possible

Treat TransmuteFrom goals with non-region inference variables as ambiguous before running transmutability, instead of computing layouts for unresolved types. The old solver already treated these goals as ambiguous, so only the next solver could hit this ICE.
@cijiugechu cijiugechu force-pushed the fix/next-solver-transmutefrom-ice branch from c3c154f to ee135be Compare April 9, 2026 02:16
@cijiugechu
Copy link
Copy Markdown
Contributor Author

can you please squash commits if possible

Squashed.

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 9, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 9, 2026

📌 Commit ee135be has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 9, 2026
rust-bors bot pushed a commit that referenced this pull request Apr 9, 2026
Rollup of 10 pull requests

Successful merges:

 - #150316 (Do not use non-wf input expectations from fudge when checking function calls)
 - #152859 (`-Znext-solver` use the trait object's own bounds instead of goal when considering builtin object bounds)
 - #154856 (Fix linking two dylibs together when both depend on profiler_builtins)
 - #153888 (Avoid stack overflow in FindExprBySpan)
 - #154991 (Fix ICE in next-solver TransmuteFrom candidate)
 - #154995 (min/max_by tests: also check result)
 - #155004 (core/num: Fix feature name for unstable `integer_extend_truncate` functions)
 - #155007 (renaming method is_impl_trait to is_opaque)
 - #155009 (meta: Add checkboxes to unsresolved questions in issue templates)
 - #155017 (Update tracking issue number of future-incompatibility lint `unstable_syntax_pre_expansion`)
@rust-bors rust-bors bot merged commit 6bd1a6c into rust-lang:main Apr 9, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 9, 2026
rust-timer added a commit that referenced this pull request Apr 9, 2026
Rollup merge of #154991 - cijiugechu:fix/next-solver-transmutefrom-ice, r=Kivooeo

Fix ICE in next-solver TransmuteFrom candidate

Treat TransmuteFrom goals with non-region inference variables as ambiguous before running transmutability, matching the old solver.

Closes #153370 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: upvar_tys called before capture types are inferred

4 participants