Use a linting node closer the parsing of #[cfg_attr]#155120
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 11, 2026
Merged
Use a linting node closer the parsing of #[cfg_attr]#155120rust-bors[bot] merged 1 commit intorust-lang:mainfrom
#[cfg_attr]#155120rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
JonathanBrouwer
approved these changes
Apr 11, 2026
Contributor
rust-bors
bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 11, 2026
…, r=JonathanBrouwer Use a linting node closer the parsing of `#[cfg_attr]` The parsing of `#[cfg_attr]` unconditionally used the crate-root as a linting node to attach lints, but the `unexpected_cfgs` lint can fire when parsing the attribute and users expect to be able to allow it at places other than the crate-root. Let's instead use the linting node id, which is unfortunately always the parent but that's better than the crate-root when you are in a sub-module. The parsing of `#[cfg]` and other already use the expansion linting node id, so no change required there. Related to rust-lang#155118
This was referenced Apr 11, 2026
rust-timer
added a commit
that referenced
this pull request
Apr 11, 2026
Rollup merge of #155120 - Urgau:check-cfg-allow-cfg_attr-mod, r=JonathanBrouwer Use a linting node closer the parsing of `#[cfg_attr]` The parsing of `#[cfg_attr]` unconditionally used the crate-root as a linting node to attach lints, but the `unexpected_cfgs` lint can fire when parsing the attribute and users expect to be able to allow it at places other than the crate-root. Let's instead use the linting node id, which is unfortunately always the parent but that's better than the crate-root when you are in a sub-module. The parsing of `#[cfg]` and other already use the expansion linting node id, so no change required there. Related to #155118
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parsing of
#[cfg_attr]unconditionally used the crate-root as a linting node to attach lints, but theunexpected_cfgslint can fire when parsing the attribute and users expect to be able to allow it at places other than the crate-root.Let's instead use the linting node id, which is unfortunately always the parent but that's better than the crate-root when you are in a sub-module.
The parsing of
#[cfg]and other already use the expansion linting node id, so no change required there.Related to #155118
r? @JonathanBrouwer
cc @jschwe