Closed
Conversation
Contributor
|
👍 |
Manishearth
force-pushed
the
ast-doc
branch
4 times, most recently
from
169034f to
9d2ffab
Compare
src/libsyntax/ast.rs
Outdated
Contributor
There was a problem hiding this comment.
Maybe "distinguishes between unsafe { ... } and { ... }.
Contributor
|
Looks great; just a few little nits. (r=me once fixed) |
|
In the future it may be worth considering converting some of the variants into struct variants so that the types are more self-documenting. |
Member
Author
|
@bors: r=huon |
Collaborator
|
📌 Commit a5828ff has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 18, 2015
I often have to run `ast-json` or look into the pretty-printer source to figure out what the fields of an AST enum mean. I've tried to document most of what I know (and some semi-obvious stuff). r? @steveklabnik f? @eddyb
src/libsyntax/ast.rs
Outdated
Contributor
There was a problem hiding this comment.
you need a line break between these two unless you want them to get rendered all together
Contributor
|
This is missing a ton of periods at the end of buches of summaries. other than that and the few other things I mentioned, looks pretty good. |
Collaborator
|
☔ The latest upstream changes (presumably #23473) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I often have to run
ast-jsonor look into the pretty-printer source to figure out what the fields of an AST enum mean. I've tried to document most of what I know (and some semi-obvious stuff).r? @steveklabnik
f? @eddyb